Todd Lipcon has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes ......................................................................
Patch Set 1: > @Todd, why does this add 5s to rebuild? is thirdparty always rebuilt? My understanding of the commit message is that this is adding 5s to every time 'cmake' is called, which is pretty regularly (eg every time I check out a different branch, the mtimes change and cmake re-runs) -- To view, visit http://gerrit.cloudera.org:8080/5857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33596a36c1f974078140360cb62b01f58211b44c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
