Dan Burkert has posted comments on this change. Change subject: [security] adjust TLS certificate verification ......................................................................
Patch Set 2: (1 comment) OK - I think the thing to do here is implement mutual cert authentication, then merge them at the same time. I'll work on that. http://gerrit.cloudera.org:8080/#/c/5865/2/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: Line 347: } else if (!ContainsKey(server_mechs, SaslMechanism::GSSAPI) && > warning: don't use else after return [readability-else-after-return] Done -- To view, visit http://gerrit.cloudera.org:8080/5865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3b1698ccd8434b8d40d567e9d0fa506e4cdc0ca Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
