Alexey Serbin has posted comments on this change. Change subject: [security] adjust TLS certificate verification ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5865/3/src/kudu/rpc/sasl_common.h File src/kudu/rpc/sasl_common.h: PS3, Line 48: const std::string& mech nit: what is the reason of having std::string as a parameter instead of 'const char*'? It seems the implementation and the usage patterns imply that it's always around 'const char*'. -- To view, visit http://gerrit.cloudera.org:8080/5865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3b1698ccd8434b8d40d567e9d0fa506e4cdc0ca Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
