Dan Burkert has posted comments on this change.

Change subject: client: rename various function calls and classes to 
ConnectToCluster
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5868/2/src/kudu/master/master.proto
File src/kudu/master/master.proto:

Line 631:   // TODO(todd): rename this RPC to ConnectToCluster() or somesuch. 
It's only used by
Could we just add an extension to the protobuf service generator that allows us 
to define two service names for a method?


-- 
To view, visit http://gerrit.cloudera.org:8080/5868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to