Todd Lipcon has posted comments on this change. Change subject: client: rename various function calls and classes to ConnectToCluster ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5868/2/src/kudu/master/master.proto File src/kudu/master/master.proto: Line 631: // TODO(todd): rename this RPC to ConnectToCluster() or somesuch. It's only used by > Could we just add an extension to the protobuf service generator that allow well, this TODO is sort of obviated by the next patch. take a look and see what you think. PS2, Line 633: use > Nit: heh, now we have singular/plural confusion. But feel free to punt. ha. woops. ya, this TODO goes away in the next patch anyway! -- To view, visit http://gerrit.cloudera.org:8080/5868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96bdfc1c6bb3758841d31d728b168bac8ac78ec0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
