Adar Dembo has posted comments on this change. Change subject: [thirdparty] Make Boost a regular dependency ......................................................................
Patch Set 8: (3 comments) Looks good, just a couple doc requests. http://gerrit.cloudera.org:8080/#/c/5818/5//COMMIT_MSG Commit Message: PS5, Line 9: However the : new timestamp type makes extensive use of boost's date_time : and, as such, we need to compile at least libboostdate_time. > We need to keep the same format and resolution so that we are memory compat Makes sense. Could you add this information to the commit message? Line 18: - Adds "thirdparty/installed/common/include" to the include > Not sure what your point is. Are you saying its ok or not? It's fine. I just documented that explicitly in case someone else was wondering the same thing I was. http://gerrit.cloudera.org:8080/#/c/5818/8/cmake_modules/FindKuduBoost.cmake File cmake_modules/FindKuduBoost.cmake: PS8, Line 18: BOOST_DATE_TIME - libboost_date_time.a, libboost_date_time.so, : # and libboost_date_time.so.1 Nit: this will be an onerous list to maintain once other boost components are added. How about just "Find Boost's libs (currently date_time) ..."? -- To view, visit http://gerrit.cloudera.org:8080/5818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I277c4fda15575e271c426735552762884cb28c43 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
