Adar Dembo has submitted this change and it was merged. Change subject: [thirdparty] Make Boost a regular dependency ......................................................................
[thirdparty] Make Boost a regular dependency For the new TIMESTAMP type we must mimic Impala's TimestampValue format to make sure that the types have the same memory format. This will allow to avoid costly conversions at scan time. Impala's type uses boost's ptime and nanosecond resolution and so must Kudu. Previously our use of boost was header-only, but the date_time library (which includes ptime) needs to be compiled. This requires that we actually compile libboost_date_time in thirparty. This patch does that and also changes the way we handle boost to treat it more like a regular dependency, both regarding the new static and shared library files and regarding headers. Since boost uses its own build system this required tinkering with jamfiles to make sure that the library is correctly built under tsan. Finally this patch also addresses a couple of other issues: - Adds "thirdparty/installed/common/include" to the include dirs explicitly (we were doing this indirectly when we added the boost include dir before). - Since FindKuduBoost.cmake now explicitly sets BOOST_INCLUDE_DIR to point to wherever boost was installed, this removes the logic that makes sure we didn't pick up boost from the system path. Change-Id: I277c4fda15575e271c426735552762884cb28c43 Reviewed-on: http://gerrit.cloudera.org:8080/5818 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <[email protected]> Reviewed-by: Adar Dembo <[email protected]> --- M CMakeLists.txt A cmake_modules/FindKuduBoost.cmake M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh 4 files changed, 124 insertions(+), 28 deletions(-) Approvals: Mike Percy: Looks good to me, but someone else must approve Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I277c4fda15575e271c426735552762884cb28c43 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
