Todd Lipcon has posted comments on this change. Change subject: java: remove unused parts of SecureRpcHelper ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5925/1/java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java File java/kudu-client/src/main/java/org/apache/kudu/client/SecureRpcHelper.java: Line 141 > We're going to need unwrap to verify channel bindings. yea, but it doesn't need all this netty junk associated with it - we'll just be unwrapping/wrapping a byte[], which is just the underlying saslClient.unwrap/wrap call -- To view, visit http://gerrit.cloudera.org:8080/5925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b70e0319060e3f2d9cc9a0ed23da7fe51b174df Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes