Todd Lipcon has posted comments on this change. Change subject: java: use a netty frame decoder instead of replaying decoder ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5926/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: Line 72: > I see red. Done Line 78: * The Hadoop RPC protocol doesn't do any checksumming as they probably > For my own edification: is this comment implying that the protocol should h yea, I think so. This is just a moved comment. I think it dates back to the OpenTSDB original source, which has plenty of "editorializing". http://gerrit.cloudera.org:8080/#/c/5926/1/java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java: Line 174: // TODO(todd): shouldn't this return here? > Yes. ok i'll make the TODO more serious and point out there is no coverage of this. -- To view, visit http://gerrit.cloudera.org:8080/5926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ec1e6f9cbbdf694fe85b7668a3c349efc26c08f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
