Alexey Serbin has posted comments on this change. Change subject: [rpc] Assume existence of TlsContext during negotiation ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5946/1/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: PS1, Line 137: tls_context_ I'm not sure I follow this: if nullptr as passed as a second parameter for ServerNegotiation constructor, then tls_context_ i nullptr, right? Then I would expect to see a check for tls_context_ prior to calling has_cert() on that. PS1, Line 364: has_cert ditto -- To view, visit http://gerrit.cloudera.org:8080/5946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I806ca360bcd168b1ab075a4c7143436a7ccbba06 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
