Dan Burkert has posted comments on this change. Change subject: [rpc] Assume existence of TlsContext during negotiation ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5946/1/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: PS1, Line 71: const security::TlsContext* tls_context > Would it be better to split it into two classes instead: { ServerNegotiatio I think PreflightCheckGSSAPI should not be creating ServerNegotiation instances with null socket and tls_context, but I think that refactor should be its own patch. -- To view, visit http://gerrit.cloudera.org:8080/5946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I806ca360bcd168b1ab075a4c7143436a7ccbba06 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
