Dan Burkert has posted comments on this change. Change subject: tls_socket: fix handling of syscall errors ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5954/1/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: Line 137: return Status::NetworkError("connection reset by peer", "", ECONNRESET); May want to make this match the others, or have the others match this. e.g. Status::NetworkError("TlsSocket::Recv", "received connection reset", ECONNRESET) -- To view, visit http://gerrit.cloudera.org:8080/5954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a0a63f861d71bd3186567ff98148476795530ab Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
