Sailesh Mukil has posted comments on this change. Change subject: tls_socket: fix handling of syscall errors ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5954/1/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: Line 127: if (error_code == SSL_ERROR_SYSCALL && ERR_peek_error() == 0) { Doesn't this have some overlap with GetSSLErrorDescription() in security/openssl_util.cc? Anyway we could use that to convey the same errors? -- To view, visit http://gerrit.cloudera.org:8080/5954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a0a63f861d71bd3186567ff98148476795530ab Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
