Jean-Daniel Cryans has posted comments on this change.

Change subject: java: set max status error length to 32KB
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6026/1/java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Status.java:

Line 37:   static final int MAX_MESSAGE_LENGTH = 32*1024;
> I think you've got it backwards -- this is the max length of the status, an
Each RpcTraceFrame has a Status. Each Status has a message, and they are 
individually capped at (now) 32KB.

What you're talking about is limiting the size of 
getHumanReadableStringForTraces(), which I guess we could also do.


-- 
To view, visit http://gerrit.cloudera.org:8080/6026
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4def8f3fe9debff1fbe72a90d5dc61c736baf42d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to