Dan Burkert has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5930/10/src/kudu/security/token_signer.cc File src/kudu/security/token_signer.cc: Line 62: DEFINE_int64(token_signing_key_propagation_seconds, 60, I'm a little confused by this flag. Shouldn't we just check that tsk_validity_seconds > 2 * tsk_rotation_seconds, and then rotate every tsk_rotation_seconds? Or let me ask another way, how does this propagation_seconds amount relate to the block comment in the header? -- To view, visit http://gerrit.cloudera.org:8080/5930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2417e2ccba6a1114db366b2f642f95362bf479c Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
