Alexey Serbin has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog ......................................................................
Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5930/11/src/kudu/security/token_signer.h File src/kudu/security/token_signer.h: PS11, Line 103: // propagation interval: 1 day > it's a bit odd that propagation = rotation interval in this diagram. Althou That's the timings of the original diagram. I thought it's worth introducing parameters which explicitly map into the essence of the TSK lifecycle, so it's easier to understand the constraints behind, etc. OK, if the consensus is that we are better off with having less parameters and we it's unlikely to need customization here, I'll drop that configurable propagation interval and assume it always equals to the rotation interval. -- To view, visit http://gerrit.cloudera.org:8080/5930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2417e2ccba6a1114db366b2f642f95362bf479c Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
