Todd Lipcon has posted comments on this change. Change subject: KUDU-1888. java: fix handling of RPCs which fail before they are sent ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6051/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 688: Deferred<R> d = request.getDeferred(); > yea, that's not a bad idea I looked into this, and it turns out it would be super invasive, because we're also relying on getDeferred() to _create_ the Deferred here. request.errback() on its own doesn't cause the creation of the Deferred if it doesn't exist, so I can't collapse these three lines down into one without major surgery. -- To view, visit http://gerrit.cloudera.org:8080/6051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ef2a215becb84c805e62f0da229b901e109193 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
