Todd Lipcon has posted comments on this change. Change subject: java: use new ConnectToMaster RPC with fallback ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6035/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java: Line 110: RpcRemoteException rre = (RpcRemoteException)result; > Well I can see an immediate use where you don't need to do this little danc oh, yea... though using it in that way would require a fairly invasive restructuring to remember the ServerInfo in the AsyncKuduClient instead of just remembering the HostAndPort. This is another area where separating the idea of the client and the RPC connection would also help -- it's silly that if we gracefully disconnect due to an idle connection that we then think we have to re-find the leader rather than using our cached one. -- To view, visit http://gerrit.cloudera.org:8080/6035 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcb7c5e56a53c788cf96468f235db73b46a3d629 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
