Todd Lipcon has posted comments on this change. Change subject: WIP: java: fetch and adopt authn token and CA from master ......................................................................
Patch Set 2: (3 comments) accidentally moved this to https://gerrit.cloudera.org/#/c/6077/ http://gerrit.cloudera.org:8080/#/c/6054/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 532: * TODO(todd) should we have a single serialized PB for the authn token > +1 done Line 1125: LOG.info("==> adopting token: {}", resp.getConnectResponse()); > The token shoudln't be logged. Done Line 1132: LOG.warn("Got more than one CA cert from leader {}: will only trust first", > Is this temporary? yea, addressed in new rev. -- To view, visit http://gerrit.cloudera.org:8080/6054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf172122f1c9152be9f954b26541499b714c440b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
