Mike Percy has posted comments on this change. Change subject: Fix checkstyle suppressions in submodule builds ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6060/4/java/pom.xml File java/pom.xml: Line 260: <suppressionsFileExpression>checkstyle.suppressions.file</suppressionsFileExpression> Hmm, it looks like this is the default value according to https://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html ... can't we remove this line? -- To view, visit http://gerrit.cloudera.org:8080/6060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c5ae0cb5fcc468d15139619c113d2a67b024f7 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
