Grant Henke has posted comments on this change. Change subject: Fix checkstyle suppressions in submodule builds ......................................................................
Patch Set 4: (1 comment) I did a sanity check by running a top level build and a few submodule builds and comparing the number of errors reported in the output. As an example the kudu_client module has 5076 errors reported reported before and after this change. http://gerrit.cloudera.org:8080/#/c/6060/4/java/pom.xml File java/pom.xml: Line 260: <suppressionsFileExpression>checkstyle.suppressions.file</suppressionsFileExpression> > Hmm, it looks like this is the default value according to https://maven.apa It is the default, but I put it here since it is referenced in the kudu_style.xml file. I found it makes it more clear how the two are linked and used. -- To view, visit http://gerrit.cloudera.org:8080/6060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c5ae0cb5fcc468d15139619c113d2a67b024f7 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
