Dan Burkert has posted comments on this change. Change subject: master: complete hooking up tokens and IPKI ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6075/3//COMMIT_MSG Commit Message: Line 17: * The TokenSigner's associated TokenVerifier is now passed in as a Did you consider adding a virtual token_verifier method to ServerBase, and having it fulfilled by a TokenSigner field in the master and TokenVerifier field in the tablet server? http://gerrit.cloudera.org:8080/#/c/6075/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 790: "couldn't self-sign master cert with CA cert"); self-sign here is a little misleading, probably best to just use 'sign'. -- To view, visit http://gerrit.cloudera.org:8080/6075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfadb427491c7b406ad2d2bc1245b3a1cdb9170 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
