Todd Lipcon has posted comments on this change. Change subject: master: complete hooking up tokens and IPKI ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6075/3//COMMIT_MSG Commit Message: Line 17: * The TokenSigner's associated TokenVerifier is now passed in as a > Did you consider adding a virtual token_verifier method to ServerBase, and Yea, I left a comment about this in the other gerrit. I couldn't quite make the ends meet, because then the Messenger would have to call back into ServerBase to get a verifier, and that's a cyclic dependency we don't want. So, I could have made this method, but then Messenger would still end up having to have shared ownership, right? -- To view, visit http://gerrit.cloudera.org:8080/6075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfadb427491c7b406ad2d2bc1245b3a1cdb9170 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
