Todd Lipcon has posted comments on this change. Change subject: java: fetch and adopt authn token and CA from master ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6077/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 550: public void importAuthenticationData(byte[] authnData) { > How about making this part of the client builder, so that it can't be done I was thinking it's actually useful to be able to re-import into an existing client, for applications which have long-lived clients or client pools (eg a spark streaming job could ship new tokens to already-running tasks, and they can just install the new token without having to do a client switcheroo) The reason it shows up in the builder on the C++ side is that the C++ side tries to connect immediately during Build() so we have to provide it up front. -- To view, visit http://gerrit.cloudera.org:8080/6077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24e71f0f5feefa36106a50074d40731911eff64b Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
