Jean-Daniel Cryans has posted comments on this change. Change subject: java: further cleanup of ConnectToCluster ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/6053/5/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java: Line 69: * @param responseD Deferred object that will hold the GetTableLocationsResponsePB object for Mind cleaning this up while you're here? http://gerrit.cloudera.org:8080/#/c/6053/5/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java: Line 34: class ConnectToClusterResponse { Why did you remove the interface audience? -- To view, visit http://gerrit.cloudera.org:8080/6053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia51175ee1b4108341959d90545e2d6733d5e80d5 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
