Todd Lipcon has submitted this change and it was merged. Change subject: java: further cleanup of ConnectToCluster ......................................................................
java: further cleanup of ConnectToCluster This changes the individual RPCs which go to masters to directly return the ConnectToMasterResponsePB. Then, these responses are aggregated in the ConnectToCluster class, and once a leader is found, a new ConnectToClusterResponse object is created which represents the result of the aggregated multi-master operation. The code to translate from the ConnectToMasterResponsePB is also moved into the ConnectToClusterResponse class where it's a little more obvious what it's doing, and called from AsyncKuduClient. This also addresses a bunch of references in comments to the old RPC names which got missed in the IDE-driven rename. Change-Id: Ia51175ee1b4108341959d90545e2d6733d5e80d5 Reviewed-on: http://gerrit.cloudera.org:8080/6053 Reviewed-by: Dan Burkert <[email protected]> Reviewed-by: Jean-Daniel Cryans <[email protected]> Tested-by: Todd Lipcon <[email protected]> --- M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToMasterRequest.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java 5 files changed, 149 insertions(+), 158 deletions(-) Approvals: Dan Burkert: Looks good to me, but someone else must approve Jean-Daniel Cryans: Looks good to me, approved Todd Lipcon: Verified -- To view, visit http://gerrit.cloudera.org:8080/6053 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia51175ee1b4108341959d90545e2d6733d5e80d5 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
