Adar Dembo has posted comments on this change. Change subject: [security] security-flags ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6052/4//COMMIT_MSG Commit Message: PS4, Line 43: 3) Nit: #2 http://gerrit.cloudera.org:8080/#/c/6052/4/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: Line 164: if (boost::iequals(FLAGS_rpc_authentication, "required")) { Would be nice to do this validation in a per-gflag validator. Better experience as it fails faster. PS4, Line 198: else if (!FLAGS_rpc_certificate_file.empty() || : !FLAGS_rpc_private_key_file.empty() || : !FLAGS_rpc_ca_certificate_file.empty()) { : return Status::InvalidArgument("--rpc_certificate_file, --rpc_private_key_file, and " : "--rpc_ca_certificate_file flags must be set as a group"); : } Likewise with this. -- To view, visit http://gerrit.cloudera.org:8080/6052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa53348b8969e83d9f794e1e0553bdec12252d9a Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
