Alexey Serbin has posted comments on this change. Change subject: [security] security-flags ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6052/4//COMMIT_MSG Commit Message: PS4, Line 7: nit: an extra space Also, consider updating the description to be have some information on the changelist. E.g., consider 'revised security-flags' or something like that. http://gerrit.cloudera.org:8080/#/c/6052/4/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: PS4, Line 84: cert, "", --rpc_certificate_file ? http://gerrit.cloudera.org:8080/#/c/6052/4/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: PS4, Line 321: if (!FLAGS_keytab.empty()) kudu::security::KerberosReinitLock()->ReadLock(); : int rc = call(); : if (!FLAGS_keytab.empty nit: any chance of FLAG_keytab to change in between (test, etc.)? If so, consider sampling value of the flag into a local variable and use its value for lock/unlock decision. -- To view, visit http://gerrit.cloudera.org:8080/6052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa53348b8969e83d9f794e1e0553bdec12252d9a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
