Dan Burkert has posted comments on this change. Change subject: [security] derive TSK params from authn token ones ......................................................................
Patch Set 4: (2 comments) I like this change, it makes it simpler to understand the key rotation intervals. http://gerrit.cloudera.org:8080/#/c/6071/4/src/kudu/security/token_signer.h File src/kudu/security/token_signer.h: PS4, Line 173: explicit explicit is only necessary with 1-argument ctors, I think? Line 174: int64_t key_rotation_seconds, Why not change the ctor to take authn_token_validity and key_rotation, instead of the three arguments, which is arguably redundant? -- To view, visit http://gerrit.cloudera.org:8080/6071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95bc64897ed16becda4ab8de6817695fdb48e9eb Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
