Todd Lipcon has posted comments on this change. Change subject: [security] derive TSK params from authn token ones ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6071/4/src/kudu/security/token_signer.h File src/kudu/security/token_signer.h: PS4, Line 173: explicit > It's possible to use initializer list as well, so it might be yea, we typically dont bother with explicit for multi-arg. I think using explicit for single-argument is the most important because it prevents the totally-implicit "suprise!!!!" construction/type conversion. Line 174: int64_t key_rotation_seconds, > I thought about that approach and decided to leave current set of parameter I think I'm with Dan, under the "YAGNI" philosophy. I also tend to think that "degrees of freedom" usually make understanding code harder to reason about, in an exponential fashion. The more constrained something can be, the easier it is to follow for me. Hopefully it doesn't involve updating a ton of tests? -- To view, visit http://gerrit.cloudera.org:8080/6071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95bc64897ed16becda4ab8de6817695fdb48e9eb Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
