Todd Lipcon has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6112/3/src/kudu/util/flags.cc File src/kudu/util/flags.cc: PS3, Line 115: flags tagged as 'sensitive'will this is somewhat uninterpretable to users, since they don't really know about flag tags. I think better to say something like "configuration flags which may include sensitive data". Line 118: "redacted."); can we also add an "all" or "*" mode? PS3, Line 275: redactLog style: REDACT_LOG or kRedactLog or something http://gerrit.cloudera.org:8080/#/c/6112/3/src/kudu/util/logging.h File src/kudu/util/logging.h: Line 62: #define KUDU_SHOULD_REDACT() (kudu::ShouldRedact(kudu::redactLog) && kudu::tls_redact_user_data) this is a hot path, I think we should be more performance-conscious, and extract a global boolean here early during startup, rather than doing a string search each time. -- To view, visit http://gerrit.cloudera.org:8080/6112 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia49ae439824351df6c87291b0828173c69ab31b0 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
