Dan Burkert has posted comments on this change. Change subject: IPKI: change X509 attribute fields ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6116/3/src/kudu/security/init.cc File src/kudu/security/init.cc: Line 66: krb5_context g_krb5_ctx; > yea, I see your point... we could consider some refactoring in the coming w Yah. I'm not entirely convinced we need globals here. We could return the local krb principal from the initialization, and then pipe that through to the self-signed cert (it's all happening at server startup). Again, not critical right now. -- To view, visit http://gerrit.cloudera.org:8080/6116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b759c327ea7758a98e675b12ff5ef49294679 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
