Todd Lipcon has posted comments on this change. Change subject: IPKI: change X509 attribute fields ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6116/1/src/kudu/security/cert-test.cc File src/kudu/security/cert-test.cc: Line 112: > Is it worth adding a reference cert with the userId and KuduKerberosPrincip that's tested in cert_management-test. http://gerrit.cloudera.org:8080/#/c/6116/1/src/kudu/security/cert.cc File src/kudu/security/cert.cc: PS1, Line 56: int nid = OBJ_txt2nid(kKuduKerberosPrincipalOidStr); : if (nid != NID_undef) return nid; > do we expect any races here? perhaps, but I checked and calling it twice just results in two 'nids' for the same object, and it still seems to work. If you feel strongly I'll add a std::call_once here -- To view, visit http://gerrit.cloudera.org:8080/6116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec3b759c327ea7758a98e675b12ff5ef49294679 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
