Todd Lipcon has posted comments on this change. Change subject: IPKI: master CA should verify x509 attributes before signing certs ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6118/2/src/kudu/integration-tests/master_cert_authority-itest.cc File src/kudu/integration-tests/master_cert_authority-itest.cc: PS2, Line 252: Status s = > Consider adding The status type already shows up in the string below (Remote error). An extra check on the status type is redundant w/ the stringification check below, isn't it? -- To view, visit http://gerrit.cloudera.org:8080/6118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I390e113220302dec335afc38d05d2ea73c965ba6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
