Andrew Wong has posted comments on this change.

Change subject: KUDU-1893 Ensure evaluation of added columns
......................................................................


Patch Set 1:

Just want to point out that this potentially breaks the abstraction of only 
evaluate when decoder-evaluation has been explicitly set to true for a given 
block. Since default columns have no block, it just goes ahead and evaluates, 
even though the rest of the column might not support decoder-level evaluation. 
AFAICT this shouldn't have any effects on the returned results.

-- 
To view, visit http://gerrit.cloudera.org:8080/6129
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic10919962d11effbb1b66d97660acd012b6b4be9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

Reply via email to