Dan Burkert has posted comments on this change. Change subject: KUDU-1893 Ensure evaluation of added columns ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6129/2/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: Line 509: sel_view.ClearBits(dst->nrows()); Is it safe to also skip copying the data if it's just being filtered? Seems like it shouldn't be necessary to fill it in. -- To view, visit http://gerrit.cloudera.org:8080/6129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic10919962d11effbb1b66d97660acd012b6b4be9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
