Andrew Wong has posted comments on this change. Change subject: KUDU-1880 Prevent eager ignoring of NULLs ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6029/3/src/kudu/tablet/tablet-scan-correctness-test.cc File src/kudu/tablet/tablet-scan-correctness-test.cc: PS3, Line 34: nullptr, n > prefer using 'nullptr' to NULL. Done Line 56: lower = std::max(size_t(0), lower); > Is this cast necessary? If so, try switching the argument order and trying Hrm.. tried both orders and it didn't take. Ended up creating a size_t(0) (probably should've from the start) Line 99: size_t expected_non_nulls = nrows_ - expected_nulls; > This should probably be a SCOPED_TRACE to cut down on test noise. SCOPED_T Done Line 208: CHECK_OK(row.SetNull(1)); > I think a lot of these casts should be unnecessary, in which case leave the Done -- To view, visit http://gerrit.cloudera.org:8080/6029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib418a4fcc2794ce2f686e864f51834fb4fb8b048 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
