Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6139
to review the following change.
Change subject: [security] add WARN_UNUSED_RESULT where possible
......................................................................
[security] add WARN_UNUSED_RESULT where possible
A lot of our security code could fail in awful ways if return codes are
ignored. This commit adds WARN_UNUSED_RESULT where possible in all
security headers (I found virtual methods and free functions produced
compiler errors with the annotation). Luckily, only test code needed to
be fixed up.
Change-Id: Ie8f5a0aea10709640e6c15c63d28b44e5de0ec6d
---
M src/kudu/security/ca/cert_management-test.cc
M src/kudu/security/ca/cert_management.h
M src/kudu/security/cert-test.cc
M src/kudu/security/cert.h
M src/kudu/security/crypto-test.cc
M src/kudu/security/crypto.h
M src/kudu/security/openssl_util.h
M src/kudu/security/tls_context.h
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.h
M src/kudu/security/token-test.cc
M src/kudu/security/token_signer.h
M src/kudu/security/token_signing_key.h
M src/kudu/security/token_verifier.h
14 files changed, 69 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/6139/1
--
To view, visit http://gerrit.cloudera.org:8080/6139
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8f5a0aea10709640e6c15c63d28b44e5de0ec6d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
