Alexey Serbin has posted comments on this change. Change subject: [security] add WARN_UNUSED_RESULT where possible ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6139/2/src/kudu/security/tls_context.h File src/kudu/security/tls_context.h: PS2, Line 152: nit: is it supposed to be 4 spaces here instead of 2? http://gerrit.cloudera.org:8080/#/c/6139/2/src/kudu/security/tls_handshake-test.cc File src/kudu/security/tls_handshake-test.cc: PS2, Line 86: CHECK_OK Why not just RETURN_NOT_OK ? PS2, Line 87: CHECK_OK ditto http://gerrit.cloudera.org:8080/#/c/6139/2/src/kudu/security/token-test.cc File src/kudu/security/token-test.cc: Line 170 thanks! This has leaked into the simpler 8-second timeout version :) -- To view, visit http://gerrit.cloudera.org:8080/6139 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8f5a0aea10709640e6c15c63d28b44e5de0ec6d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
