Will Berkeley has posted comments on this change. Change subject: Add test for implicit partitions ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6153/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS2, Line 664: specifing nit: specifying PS2, Line 668: & nit: We can capture nothing. PS2, Line 679: gscoped_ptr nit: unique_ptr here and below -- To view, visit http://gerrit.cloudera.org:8080/6153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
