Dan Burkert has posted comments on this change. Change subject: Add test for implicit partitions ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/6153/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS2, Line 664: specifing > nit: specifying Done PS2, Line 668: & > nit: We can capture nothing. Done Line 672: CHECK_OK(builder.Build(&tokens)); > ASSERT_OK? ASSERT_OK only works in functions returning void. PS2, Line 679: gscoped_ptr > nit: unique_ptr here and below Done PS2, Line 689: unique_ptr<KuduTableAlterer> alterer(client_->NewTableAlterer(table_name)); : ASSERT_OK(alterer->DropRangePartition(schema_.NewRow(), schema_.NewRow())->Alter()); : ASSERT_EQ(0, count_tablets(table.get())); > What is the purpose of this part of each subtest? This is one way to ensure that the implicit tablets are actually 'unbounded'. If they had some other bound, dropping them via empty rows would fail. -- To view, visit http://gerrit.cloudera.org:8080/6153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
