Adar Dembo has posted comments on this change.

Change subject: [linked list test] use timeout for WaitAndVerify in all modes
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6155/1/src/kudu/integration-tests/linked_list-test-util.h
File src/kudu/integration-tests/linked_list-test-util.h:

PS1, Line 762:         // Scans in READ_LATEST mode will, by design, likely 
return a stale view of the tablet
             :         // so, in this case, retry.
This suggests that, authn token expiration notwithstanding, retries for 
FINISH_WITH_SNAPSHOT_SCAN are undesired, as it should return the right results 
immediately.

So, if you're going to address the root cause (i.e. add client retry on token 
expiration) anyway, why is this change desirable?


-- 
To view, visit http://gerrit.cloudera.org:8080/6155
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If129738fbeef5394dfd1bcb160121e1d4131b3cc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-HasComments: Yes

Reply via email to