Mike Percy has posted comments on this change. Change subject: [linked list test] use timeout for WaitAndVerify in all modes ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6155/1/src/kudu/integration-tests/linked_list-test-util.h File src/kudu/integration-tests/linked_list-test-util.h: PS1, Line 762: // Scans in READ_LATEST mode will, by design, likely return a stale view of the tablet : // so, in this case, retry. > Without this change the code never returns from the do {} while(); loop if This method is allowed to be invoked right after a cluster restart, when tablets are still being initialized, so I think not the timeout logic this way originally was just an oversight. -- To view, visit http://gerrit.cloudera.org:8080/6155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If129738fbeef5394dfd1bcb160121e1d4131b3cc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
