Hello David Ribeiro Alves, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6159
to review the following change.
Change subject: Misc optimizations to BinaryPlainBlockDecoder
......................................................................
Misc optimizations to BinaryPlainBlockDecoder
Looking at a profile while running a YCSB read workload, I noticed that
BinaryPlainDecoder had done a really poor job of inlining
vector::push_back when building the offsets array.
This switches away from using a vector there and instead uses a simple
buffer/pointer view into the buffer. I also rearranged a bit of other
code and added PREDICT_FALSEs to try to get the code into a tighter
loop.
Change-Id: I5b5061818de36dc268cd5d4fc8553bceeca5dadd
---
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/binary_plain_block.h
2 files changed, 37 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/6159/1
--
To view, visit http://gerrit.cloudera.org:8080/6159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b5061818de36dc268cd5d4fc8553bceeca5dadd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
