Hello David Ribeiro Alves, Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6163

to review the following change.

Change subject: KUDU-1899. Fix support for empty string keys
......................................................................

KUDU-1899. Fix support for empty string keys

We've never prevented users from inserting a row with "" as a key. However, a
faulty assertion in diskrowset.cc caused the tablet server to crash on flush in
this case.

This adds a new end-to-end test via the client which inserts, updates, and 
deletes
a row with a "" key. It caused a crash prior to this patch.

Change-Id: I779f25afe6d39d91067b1e7c1238797ec2ac0295
---
M src/kudu/client/client-test.cc
M src/kudu/tablet/diskrowset.cc
2 files changed, 81 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/6163/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I779f25afe6d39d91067b1e7c1238797ec2ac0295
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>

Reply via email to