Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown ......................................................................
Patch Set 1: (5 comments) > (4 comments) > > As a general point, it sucks that Status isn't full-featured enough > to include this additional bit of information. IIRC Mike proposed a > sweeping change to Status handling a couple years ago which would > have made it versatile enough to include this case. It would be > interesting to hear his comments on this. Yep, it might be handy to have that. Probably, having this use-case might help to make it happen :) http://gerrit.cloudera.org:8080/#/c/6170/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 204: using std::bind; > warning: using decl 'bind' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/6170/1/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: Line 20: #include <functional> > Is this for existing code? Or something new? Now it's just for the existing code: StartTabletCopy() method's signature has std::function<...> as a parameter. PS1, Line 585: master's > Nit: to make it clearer that this is a variant of InitCertAuthority(), can Done Line 596: // Store CA certificate information into the system table. > Doc what is_not_leader_error means. Done http://gerrit.cloudera.org:8080/#/c/6170/1/src/kudu/master/sys_catalog.h File src/kudu/master/sys_catalog.h: Line 153: bool* is_not_leader); > Maybe rename to "error_is_not_leader" or "is_not_leader_error"? Done -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
