Dan Burkert has posted comments on this change. Change subject: [catalog_manager] proper handling of catalog shutdown ......................................................................
Patch Set 4: (4 comments) In general I'm not a fan of the additional bool* out params, when the callers could just check resp.error().code() == TabletServerErrorPB::NOT_THE_LEADER The bool also doesn't seem to be used in non-test code. http://gerrit.cloudera.org:8080/#/c/6170/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 458: { New scope seems redundant. Line 459: bool error_is_not_leader; What is this boolean doing? It's passed as an out parameter to TryGenerateNewTskUnlocked, and then not used thereafter. Line 763: if (s.IsNotFound()) { This method might be simpler if it's structured as a single if/else chain: if (s.ok()) { return InitCertAuth... } else if (s.IsNotFound()) { ... } else { return s; } Line 764: LOG(INFO) << "Did not find CA certificate and key for Kudu IPKI, " This is going to be pretty chatty, perhaps VLOG? -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
