Adar Dembo has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6173/1//COMMIT_MSG Commit Message: PS1, Line 9: fix > Done You missed the 'e' in fixes. http://gerrit.cloudera.org:8080/#/c/6173/1/src/kudu/util/flags.cc File src/kudu/util/flags.cc: PS1, Line 420: // Redact the flag tagged as 'sensitive', if --redact is set : // with 'flag'. Otherwise, return its value as-is. If EscapeMode : // is set to HMTL_ESCAPE, return html e > But CheckFlagAndRedact is not a "public" function, it is only used inside f My bad; I mistook this for CommandLineFlagsIntoString(). http://gerrit.cloudera.org:8080/#/c/6173/3/src/kudu/util/flags.h File src/kudu/util/flags.h: Line 54: HMTL_ESCAPE, HTML Line 55: NON_ESCAPE How about calling the two options "HTML" and "NONE"? Since they're qualified with EscapeMode, the extra "_ESCAPE" doesn't really add any information. -- To view, visit http://gerrit.cloudera.org:8080/6173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ebb0befe6bacb0fc90d50a1e34870656041a01 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
