Todd Lipcon has posted comments on this change. Change subject: KUDU-1898: /varz page doesn't HTML-escape flag values ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/6173/4/src/kudu/server/default-path-handlers.cc File src/kudu/server/default-path-handlers.cc: PS4, Line 121: string tag_value; : if (as_text) { : tag_value = CommandlineFlagsIntoString(EscapeMode::NONE); : } else { : tag_value = CommandlineFlagsIntoString(EscapeMode::HMTL); : } how about using ternary? tag_value = CommandLineFlagsIntoString(as_text ? EscapeMode::NONE : EscapeMode::HTML); also, typo in the enum value 'HTML' http://gerrit.cloudera.org:8080/#/c/6173/4/src/kudu/util/flags.cc File src/kudu/util/flags.cc: Line 422: // is set to HMTL_ESCAPE, return html escaped string. typo HTML, also the flag value is 'HTML' not 'HTML_ESCAPE' right now http://gerrit.cloudera.org:8080/#/c/6173/4/src/kudu/util/flags.h File src/kudu/util/flags.h: Line 53: enum EscapeMode { use an enum class? Line 62: std::string CommandlineFlagsIntoString(kudu::EscapeMode mode); no need to fully qualify 'kudu::' here because this is already in the kudu namespace -- To view, visit http://gerrit.cloudera.org:8080/6173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64ebb0befe6bacb0fc90d50a1e34870656041a01 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
