Dan Burkert has posted comments on this change. Change subject: spark: send authentication credentials to tasks ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6081/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: Line 62: private[kudu] var authnCredentials : Array[Byte] = > nope, because then we end up with a circular dependency of initialization o Not sure I fully understand. To me this code looks a little suspicious because a field is being initialized (which happens in the ctor), with the result of a lazy field. So in effect, that field is not lazy at all. Not to mention the circular dependency. But regardless, I think this can be a val, since it's never assigned to. So, should it be a lazy val? -- To view, visit http://gerrit.cloudera.org:8080/6081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7be2c72eb801c3ee10e576ce8705c3b5997dffd9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Chris George <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
